Skip to content

[src] Include the assembly-wide availability attributes when building the api definitions. - #22301

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/minimum-everywhere
Mar 6, 2025
Merged

[src] Include the assembly-wide availability attributes when building the api definitions.#22301
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/minimum-everywhere

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Mar 5, 2025

Copy link
Copy Markdown
Member

This fixes all of these availability warnings:

This call site is reachable on all platforms. 'FieldAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
This call site is reachable on all platforms. 'iOSAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
This call site is reachable on all platforms. 'MacAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
This call site is reachable on all platforms. 'AdviceAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.

This also required making sure we define the same conditional compilation symbols
when compiling the api definitions as when we compile the rest of the sources.

@rolfbjarne
[src] Include the assembly-wide availability attributes when building…
195fda2 
… the api definitions.

This fixes all of these availability warnings:

> This call site is reachable on all platforms. 'FieldAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
> This call site is reachable on all platforms. 'iOSAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
> This call site is reachable on all platforms. 'MacAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
> This call site is reachable on all platforms. 'AdviceAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.

This also required making sure we define the same conditional compilation symbols
when compiling the api definitions as when we compile the rest of the sources.
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

✅ [PR Build #195fda2] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

✅ [PR Build #195fda2] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

✅ [PR Build #195fda2] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

💻 [PR Build #195fda2] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

💻 [PR Build #195fda2] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

💻 [PR Build #195fda2] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

💻 [PR Build #195fda2] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #195fda2] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #195fda2] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 114 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 195fda2226b70cf929bbefb3757b870cc03e52f1 [PR build]

@rolfbjarne
rolfbjarne merged commit a771be8 into main Mar 6, 2025
@rolfbjarne
rolfbjarne deleted the dev/rolf/minimum-everywhere branch March 6, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto