🔴 Live TV: dotnet/macios/pull/

rolfbjarne · 2023-08-08T17:21:04Z

Add partial support for the [Preserve] attribute for NativeAOT. This is done by injecting an equivalent [DynamicDependency] attribute. The partial support comes from the fact that there's no way to map a conditional preserve attribute ([Preserve (Conditional = true)]) to a [DynamicDependency] attribute, so we report a warning instead.

For non-conditional [Preserve] attributes, we'll now add a [DynamicDependency] attribute to the assembly's module constructor for the type/member in question, effectively rooting it.

This makes it possible to fully link all our test suites when NativeAOT (otherwise NativeAOT would just link out all the tests, leaving the test suites empty - and unfortunately green, so this was a rather accidental discovery).

…ationAwareSubStep This improves error reporting.

…cDependency attributes. Add support for mapping Preserve attributes to DynamicDependency attributes, and use for NativeAOT. This fixes a problem where NativeAOT would trim away all our tests in our test suites.

vs-mobiletools-engineering-service2 · 2023-08-15T16:22:11Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c6576d3c5dfa94f1e6621554b695020d7f27959a [PR build]

vs-mobiletools-engineering-service2 · 2023-08-15T17:02:15Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: c6576d3c5dfa94f1e6621554b695020d7f27959a [PR build]

vs-mobiletools-engineering-service2 · 2023-08-15T17:08:09Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-15T17:12:48Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-15T17:16:31Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-17T10:57:13Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 232 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c6576d3c5dfa94f1e6621554b695020d7f27959a [PR build]

dalexsoto

green > gred

Make 'Full' the default link mode for all platforms for NativeAOT because: * It will achieve the best app size. * NativeAOT is not a drop-in replacement that's guaranteed to work - there are already known features NativeAOT don't support (and may never support), so this may be an opportunity for app developers (and component vendors) to make their products trimmer safe. * NativeAOT will be in preview in .NET 8, so we can change our mind later if it turns out to cause too many problems. * In some cases NativeAOT might require trimming, because we may optimize/rewrite assemblies to be NativeAOT-compatible to support existing libraries. This requires #18666 to be merged first, so that ests aren't linked away.

This is a follow-up to #18666 The idea is to transform `[Preserve(Conditional = true)]` into `[DynamicDependency(signature, type)]` on the static constructor of the given type: ```c# class MyClass { [Preserve (Conditional = true)] public void MyMethod () { } // transformed into ... [DynamicDependency ("MyMethod", typeof (MyClass))] static MyClass() { /* either the existing cctor or a new empty cctor */ } public void MyMethod () { } } ```

This is a follow-up to #18666 This PR resolves the following warnings that I've seen in build logs when running MySingleView with NativeAOT: ``` ILLink : warning IL2034: <Module>..cctor(): The 'DynamicDependencyAttribute' could not be analyzed. [/..../xamarin/xamarin-macios/tests/dotnet/MySingleView/MySingleView.csproj] ILLink : warning IL2034: <Module>..cctor(): The 'DynamicDependencyAttribute' could not be analyzed. [/..../xamarin/xamarin-macios/tests/dotnet/MySingleView/MySingleView.csproj] ... ``` The generated module cctor code looks like this: ```c# internal class <Module> { [DynamicDependency("InvokeConformsToProtocol(ObjCRuntime.NativeHandle)", typeof(NSObject))] [DynamicDependency("Foundation.NSObject", null)] [DynamicDependency("ConformsToProtocol(ObjCRuntime.NativeHandle)", typeof(NSObject))] [DynamicDependency("Foundation.NSObject", null)] // ... static <Module>() { // ... } } ``` The `[DynamicDependency("T", null)]` attributes are invalid. We could change them to `[DynamicDependency(DynamicallyAccessedMemberTypes.None, typeof(T))]` but I think that attribute is redundant because the type itself is always already preserved through the attribute that precedes it with a selector of one of its methods/fields.

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the use-dynamicdependency-for-preserve-attributes branch from d2e181a to 69ec2d3 Compare August 11, 2023 09:27

This comment has been minimized.

Sign in to view

rolfbjarne mentioned this pull request Aug 15, 2023

[dotnet] Make 'Full' the default link mode for NativeAOT. #18734

Merged

rolfbjarne added 2 commits August 15, 2023 16:25

[dotnet-linker] Make ApplyPreserveAttributeBase inherit from Configur…

fafa46e

…ationAwareSubStep This improves error reporting.

[dotnet-linker] Add support for mapping Preserve attributes to Dynami…

c6576d3

…cDependency attributes. Add support for mapping Preserve attributes to DynamicDependency attributes, and use for NativeAOT. This fixes a problem where NativeAOT would trim away all our tests in our test suites.

rolfbjarne force-pushed the use-dynamicdependency-for-preserve-attributes branch from 69ec2d3 to c6576d3 Compare August 15, 2023 14:25

This comment has been minimized.

Sign in to view

rolfbjarne changed the title ~~[DRAFT] Testing misc NativeAOT fixes.~~ [NativeAOT] Add support for [Preserve] attributes Aug 17, 2023

rolfbjarne marked this pull request as ready for review August 17, 2023 06:59

dalexsoto approved these changes Aug 18, 2023

View reviewed changes

rolfbjarne merged commit 19b2b37 into dotnet:net8.0 Aug 18, 2023

rolfbjarne deleted the use-dynamicdependency-for-preserve-attributes branch August 18, 2023 14:49

This was referenced Aug 24, 2023

[NativeAOT] Add support for conditional [Preserve] attributes #18803

Merged

[NativeAOT] Remove unnecessary [DynamicDependency] attributes #18808

Merged

Conversation

rolfbjarne commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 15, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 15, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 15, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 15, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 15, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 17, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rolfbjarne commented Aug 8, 2023 •

edited

Loading