Skip to content

[src] Fix containing namespace/framework for AVCustomRoutingControllerDelegate. - #18137

Merged
rolfbjarne merged 3 commits into
dotnet:mainfrom
rolfbjarne:fix-namespace-avcustomroutingontrollerdelegate
Apr 26, 2023
Merged

[src] Fix containing namespace/framework for AVCustomRoutingControllerDelegate.#18137
rolfbjarne merged 3 commits into
dotnet:mainfrom
rolfbjarne:fix-namespace-avcustomroutingontrollerdelegate

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Apr 25, 2023

Copy link
Copy Markdown
Member

The AVCustomRoutingControllerDelegate protocol was incorrectly placed in the
AVKit framework, instead of the AVRouting framework where it currently belongs
(this might have been a change between betas at some point).

So move AVCustomRoutingControllerDelegate to the AVRouting namespace, but only
in XAMCORE_5_0, because otherwise it would be a breaking change.

In the meantime, special case the AVCustomRoutingControllerDelegate type so
that we correctly link with the AVRouting framework when it's used.

@rolfbjarne
[src] Fix containing namespace/framework for AVCustomRoutingControlle…
dde10f2 
…rDelegate.

The AVCustomRoutingControllerDelegate protocol was incorrectly placed in the
AVKit framework, instead of the AVRouting framework where it currently belongs
(this might have been a change between betas at some point).

So move AVCustomRoutingControllerDelegate to the AVRouting namespace, but only
in XAMCORE_5_0, because otherwise it would be a breaking change.

In the meantime, special case the AVCustomRoutingControllerDelegate type so
that we correctly link with the AVRouting framework when it's used.
@rolfbjarne
rolfbjarne requested a review from dalexsoto as a code owner April 25, 2023 12:30
@github-actions

github-actions Bot commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 570b2c652d0fcb01f8fd5bb537b41112cb7e06a8 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1196.Ventura
Hash: 570b2c652d0fcb01f8fd5bb537b41112cb7e06a8 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 570b2c652d0fcb01f8fd5bb537b41112cb7e06a8 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 570b2c652d0fcb01f8fd5bb537b41112cb7e06a8 [PR build]

@rolfbjarne
rolfbjarne merged commit 6f20a28 into dotnet:main Apr 26, 2023
@rolfbjarne
rolfbjarne deleted the fix-namespace-avcustomroutingontrollerdelegate branch April 26, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
+2 more reviewers
@stephen-hawley stephen-hawley stephen-hawley approved these changes
@haritha-mohan haritha-mohan haritha-mohan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @stephen-hawley @haritha-mohan