Repository navigation
[Mono.Android] Suppress DSA client-certificate compatibility alert - #12528
Merged
Merged
Conversation
Retain the DSA client-certificate fallback while narrowly suppressing the SM03800 finding at the intentional use site. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a narrowly scoped CodeQL suppression for rule SM03800 (Unapproved usage of DSA) in AndroidMessageHandler.GetKeyEntry() to preserve compatibility with application/customer-provided client certificates that use DSA keys, without changing runtime behavior.
Changes:
- Adds a compatibility rationale comment immediately above the DSA private-key fallback.
- Adds an inline
// CodeQL [SM03800]suppression marker on the DSA fallback branch.
simonrozsival
approved these changes
Aug 26, 2026
simonrozsival
pushed a commit
that referenced
this pull request
Aug 27, 2026
…12528) ## Summary Adds `CodeQL [SM03800]` only to the DSA client-certificate fallback in `AndroidMessageHandler.GetKeyEntry()`. DSA remains for customer-provided certificate compatibility after RSA and ECDSA are preferred. It is not used for Microsoft-controlled signing, issuance, key generation, or password storage; removing it would break compatibility. No behavior changes. ## Validation - One scoped `SM03800` marker - Comment-only executable diff - `git diff --check` No behavioral tests were needed for this comment-only suppression. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
CodeQL [SM03800]only to the DSA client-certificate fallback inAndroidMessageHandler.GetKeyEntry(). DSA remains for customer-provided certificate compatibility after RSA and ECDSA are preferred. It is not used for Microsoft-controlled signing, issuance, key generation, or password storage; removing it would break compatibility. No behavior changes.Validation
SM03800markergit diff --checkNo behavioral tests were needed for this comment-only suppression.