Skip to content

[fix-finder] Localize missing NDK toolchain warning - #12481

Merged
jonathanpeppers merged 1 commit into
mainfrom
fix-finder/localize-ndk-toolchain-warning-7531f39937648ace
Aug 24, 2026
Merged

jonathanpeppers merged 1 commit into
mainfrom
fix-finder/localize-ndk-toolchain-warning-7531f39937648ace

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

AI-generated fix. Produced by the nightly-fix-finder agentic workflow.

Problem

NdkToolsWithClangNoPlatforms emitted a hardcoded warning when an architecture-specific toolchain directory was missing, so the customer-facing message bypassed localization and had no XA code.

Fix

Replace the literal in WithClangNoPlatforms.cs with the existing Properties.Resources.XA5101_Toolchain message and emit it as coded warning XA5101.

Validation

  • AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk ./build.sh Prepare β€” passed
  • Built the four missing lightweight project references individually with ./dotnet-local.sh build ... -m:1 --no-restore β€” passed
  • GRADLE_USER_HOME=/tmp/gh-aw/agent/gradle AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk ./dotnet-local.sh build src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj -m:1 --no-restore -p:BuildProjectReferences=false β€” passed (one pre-existing duplicate source warning)

Fix-finder metadata

  • Script: 08-string-literal-error-messages
  • Score: 29/30 (actionability: 10, safety: 9, scope: 10)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • southcentralus0.in.applicationinsights.azure.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "southcentralus0.in.applicationinsights.azure.com"

See Network Configuration for more information.

Generated by Nightly Fix Finder Β· gpt56 Β· 123.5 AIC Β· βŒ– 42.9 AIC Β· ⊞ 23.8K Β· β—·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers merged commit 70e2c19 into main Aug 24, 2026
44 checks passed
@jonathanpeppers
jonathanpeppers deleted the fix-finder/localize-ndk-toolchain-warning-7531f39937648ace branch August 24, 2026 13:33
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant