Repository navigation
[build] Fix BinSkim analyzeTargetGlob pattern - #10953
Merged
Merged
Conversation
jonathanpeppers
requested review from
grendello and
simonrozsival
as code owners
March 16, 2026 20:59
The +| prefix is BinSkim CLI syntax that the 1ES Guardian wrapper cannot parse: 'Could not parse glob pattern'. Remove the +| prefix and keep the glob pattern for Guardian compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
force-pushed
the
dev/peppers/fix-binskim
branch
from
March 16, 2026 21:00
498e1dc to
039e943
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a BinSkim configuration change in the Azure Pipelines 1ES SDL settings that introduced an unsupported analyzeTargetGlob pattern, which was breaking BinSkim execution in the 1ES Guardian wrapper.
Changes:
- Removed the
binskim.analyzeTargetGlob: +|bin\Build*\**setting that was causing “Could not parse glob pattern”. - Kept
scanOutputDirectoryOnly: true, relying on staging-output-only scanning to constrain the scan scope.
jonathanpeppers
changed the title
analyzeTargetGlob pattern
jonathanpeppers
added
the
copilot
This was referenced Mar 17, 2026
jonathanpeppers
added a commit
that referenced
this pull request
Mar 19, 2026
Revert the `analyzeTargetGlob` customization added in PRs #10940, #10953, and #10961. The custom glob patterns caused more problems than they solved: - `+|bin\Build*\**` — Guardian can't parse `+|` prefix (#10953) - `bin\Build*\**` — breaks the 'Convert NuGet to MSI' job which has no `bin\Build*\` directory (#10961) - `bin\Build*\**;bin\msi-nupkgs\**` — Guardian can't parse semicolons, breaks every job Remove `analyzeTargetGlob` entirely and keep only `scanOutputDirectoryOnly: true`, which is the default configuration that worked before #10940.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
+|prefix is BinSkim CLI syntax that the 1ES Guardian wrappercannot parse: 'Could not parse glob pattern'. Remove the
+|prefixand keep the glob pattern for Guardian compatibility.