Skip to content

cleanup TUI lines after switching to "compact" mode - #10203

Merged
ndeloof merged 1 commit into
docker:v2from
ndeloof:TUI
Jan 26, 2023
Merged

ndeloof merged 1 commit into
docker:v2from
ndeloof:TUI

Conversation

@ndeloof

@ndeloof ndeloof commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

What I did
cleanup stale lines after switching to "compact" mode (skip child events)

Related issue
closes #10201

@codecov

codecov Bot commented Jan 25, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 73.89% // Head: 73.89% // No change to project coverage πŸ‘

Coverage data is based on head (6dbcd63) compared to base (d47f0f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10203   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files           2        2           
  Lines         272      272           
=======================================
  Hits          201      201           
  Misses         60       60           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@ndeloof
ndeloof force-pushed the TUI branch 2 times, most recently from ac5dbcd to 5f77838 Compare January 25, 2023 11:43
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof
ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team January 25, 2023 12:19

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard laurazard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dimaqq dimaqq left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! πŸš€

@ndeloof
ndeloof merged commit aa31387 into docker:v2 Jan 26, 2023
@ndeloof
ndeloof deleted the TUI branch January 26, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI leaves stale lines when there's too much lines to display

4 participants