Skip to content

Ignore containers not created by Compose - #10177

Merged
ndeloof merged 2 commits into
docker:v2from
laurazard:filter-config-hash
Jan 17, 2023
Merged

ndeloof merged 2 commits into
docker:v2from
laurazard:filter-config-hash

Conversation

@laurazard

@laurazard laurazard commented Jan 17, 2023 •

Copy link
Copy Markdown
Member

What I did

Ignore containers missing the com.docker.compose.config-hash label (from #10162 (comment))

Also adds tests and some cucumber helper functions to pass in a Dockerfile.

Related issue

fixes #10162

(not mandatory) A picture of a cute animal, if possible in relation to what you did

image

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@codecov

codecov Bot commented Jan 17, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 73.89% // Head: 72.79% // Decreases project coverage by -1.11% ⚠️

Coverage data is based on head (4f681fb) compared to base (5a2b7b8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10177      +/-   ##
==========================================
- Coverage   73.89%   72.79%   -1.11%     
==========================================
  Files           2        2              
  Lines         272      272              
==========================================
- Hits          201      198       -3     
- Misses         60       62       +2     
- Partials       11       12       +1     
Impacted Files Coverage Ξ”
pkg/e2e/framework.go 70.98% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@laurazard
laurazard force-pushed the filter-config-hash branch 2 times, most recently from 402d43e to 0123a30 Compare January 17, 2023 15:13
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@laurazard
laurazard requested review from a team, StefanScherer, glours, milas, ndeloof, nicksieger and ulyssessouza and removed request for a team January 17, 2023 15:36
@ndeloof
ndeloof merged commit 0b1c867 into docker:v2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] docker compose up still have errors strconv.Atoi: parsing "": invalid syntax

3 participants