Skip to content

fix typo - #10149

Merged
laurazard merged 1 commit into
docker:v2from
TColl:typo-fix
Jan 12, 2023
Merged

fix typo#10149
laurazard merged 1 commit into
docker:v2from
TColl:typo-fix

Conversation

@TColl

@TColl TColl commented Jan 6, 2023 •

Copy link
Copy Markdown
Contributor

What I did

Tiny PR to fix a typo in the CLI which alerts when a container hasn't exited successfully and you have other containers waiting for it to do so.

Related issue
None raised - this is a single character change

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@laurazard laurazard left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ₯³ Just need you to sign-off your commit to satisfy DCO

Signed-off-by: Tom Collingwood <tomcollingwood@yahoo.co.uk>
@TColl

TColl commented Jan 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks πŸ₯³ Just need you to sign-off your commit to satisfy DCO

I've signed my original commit and force-pushed over it now πŸ‘

@codecov

codecov Bot commented Jan 12, 2023

Copy link
Copy Markdown

Codecov Report

Base: 76.98% // Head: 72.79% // Decreases project coverage by -4.19% ⚠️

Coverage data is based on head (f2088bb) compared to base (9d12eec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10149      +/-   ##
==========================================
- Coverage   76.98%   72.79%   -4.20%     
==========================================
  Files           2        2              
  Lines         252      272      +20     
==========================================
+ Hits          194      198       +4     
- Misses         51       62      +11     
- Partials        7       12       +5     
Impacted Files Coverage Ξ”
pkg/e2e/framework.go 70.98% <0.00%> (-4.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@laurazard
laurazard merged commit 2aa88b5 into docker:v2 Jan 12, 2023
@TColl
TColl deleted the typo-fix branch January 12, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants