Repository navigation
feat(task): add --members flag to run tasks in workspace members only - #35748
Merged
Merged
Conversation
bartlomieju
added a commit
that referenced
this pull request
Aug 4, 2026
…d tests - Relocate parse_memory_size_mb / parse_positive_seconds into deno_cli_parser::convert as the single source of truth, used by both the clap value parsers and the zero-cost parser. - Define --max-memory/--max-cpu-time/--max-time on run & compile in the cli_parser defs (RESOURCE_LIMIT_ARGS) and parse them in convert, keeping the two parsers in sync (matching #35748/#35751). - Add flag-parsing unit tests (suffixes, invalid rejection, subcommand gating) in flags.rs and clap-parity tests in tests_full.rs.
bartlomieju
added a commit
that referenced
this pull request
Aug 4, 2026
`--members` (#35748) landed on main after this branch forked and updated flags.rs/defs.rs/convert.rs but not tests_full.rs, leaving `cargo test -p deno_cli_parser` failing to compile on main.
bartlomieju
added a commit
that referenced
this pull request
Aug 4, 2026
Five spec tests failed on every platform: - `fmt --ext=xml`/`=svg` (#36149): the value list wasn't updated. - `task --members` with `-r` (#35748): the conflict with --recursive and --filter wasn't declared, so it silently proceeded. - `add`/`remove`/`info --min-dep-age` (#36099): the flag parsed but the conversion never read it, so it had no effect. - `vendor --help`: continuation lines were indented to a hardcoded column 28 rather than to the description column, so help strings that carry their own leading indent (as clap's do) came out 2 columns deep. Also restores clap's conflict message format ('--output <output>' rather than 'output'); the branch had weakened main's transpile fixture to match the shorter form, so that fixture is restored too.
nathanwhitbot
pushed a commit
to nathanwhitbot/deno
that referenced
this pull request
Aug 4, 2026
…lizers `--members` (denoland#35748) added `TaskFlags::members` to the canonical flag types in libs/cli_parser/src/flags.rs and updated the clap tests in cli/args/flags.rs, but not the parity tests in libs/cli_parser/src/tests_full.rs. That leaves `deno_cli_parser`'s test target failing to compile with 20x E0063 "missing field `members`", which breaks `cargo clippy --all-targets` (the lint CI job) on main and on every open PR. Test-only fix: add `members: false` to the 20 `TaskFlags` initializers, matching the corresponding expectations in cli/args/flags.rs.
bartlomieju
added a commit
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no way to run a task in all workspace members without
also running it in the workspace root.
--recursivealways includes theroot, so a root task that fans out with
deno task -r buildwould recurseinto itself.
--filter '*'happens to skip the root, but only as long asthe root config has no
namefield; a named root matches the filter andgets included again. Other runners support this directly: npm via
npm run --workspaces(root excluded unless--include-workspace-root)and pnpm via
pnpm -r(root excluded by default).This adds a
--membersflag todeno taskthat runs the task in everyworkspace member and never in the root, regardless of whether the root
config has a name. It conflicts with
--recursiveand--filter. Theflag is also added to the
deno_cli_parserdefinitions to keep the twoparsers in sync.
Closes #29375