Repository navigation
support psi - #308
Merged
Merged
support psi#308
Conversation
zouyee
marked this pull request as draft
November 24, 2023 08:05
zouyee
force-pushed
the
main
branch
2 times, most recently
from
December 2, 2023 00:06
f873e57 to
a934ff5
Compare
zouyee
marked this pull request as ready for review
December 2, 2023 00:07
Contributor
Author
|
@fuweid PTAL |
Contributor
Author
|
@dmcgowan PTAL |
Member
|
Can you rebase this on the tip of |
Contributor
Author
done |
fuweid
reviewed
Dec 8, 2023
fuweid
reviewed
Dec 11, 2023
fuweid
left a comment
fuweid
left a comment
Member
There was a problem hiding this comment.
Basically, it looks good.
But, would you please squash into one commit and add two unit tests for Stats to cover PSI? Thanks
zouyee
force-pushed
the
main
branch
2 times, most recently
from
December 12, 2023 07:48
96b4ff9 to
34283c5
Compare
Contributor
Author
done |
fuweid
reviewed
Dec 13, 2023
Signed-off-by: zouyee <zouyee1989@gmail.com>
Contributor
Author
|
@samuelkarp ping |
dmcgowan
approved these changes
Dec 21, 2023
Closed
33 of 34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: containerd/containerd#9411