Repository navigation
migrate tests to attribute-specific test files - #857
Merged
Merged
Conversation
glours
approved these changes
Mar 24, 2026
glours
left a comment
glours
left a comment
Collaborator
There was a problem hiding this comment.
Sounds good to me, just one nit, I let you decide to address it or not
| source: \\.\pipe\docker_engine | ||
| target: \\.\pipe\docker_engine | ||
| image: | ||
| subpath: /foo |
Collaborator
There was a problem hiding this comment.
NIT: Either we don't need it, or we should add an assertion to verify it.
Collaborator
Author
There was a problem hiding this comment.
I wonder we should detect volume sub-attribute doesn't match the type and report an error - this may be a breaking change for a few users
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
attribute_tests
branch
from
March 24, 2026 13:28
ad98eac to
cbcfd17
Compare
ndeloof
enabled auto-merge (rebase)
March 24, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #855
tests from loader_test.go are migrated into attribute-specific test files