Skip to content

Show image viewer when clicking url preview thumbnail - #2309

Merged
ajbura merged 4 commits into
cinnyapp:devfrom
LeaPhant:large-url-preview
Mar 14, 2026
Merged

ajbura merged 4 commits into
cinnyapp:devfrom
LeaPhant:large-url-preview

Conversation

@LeaPhant

Copy link
Copy Markdown
Contributor

Description

Show an image viewer when clicking the thumbnail in the url preview, similar to Element. Uses the same code as image content, maybe some deduplication necessary.

showcase of image preview

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions

github-actions Bot commented Apr 19, 2025 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ βœ…
Posted by the CLA Assistant Lite bot.

@LeaPhant

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

ajbura added a commit to cinnyapp/cla that referenced this pull request Apr 19, 2025
@LeaPhant

Copy link
Copy Markdown
Contributor Author

Alright I'm pretty happy with it now. Feel free to request changes as I'm not sure if this is the correct location for the new component.

@github-actions

Copy link
Copy Markdown

Preview: https://2309--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@trash-pandy

Copy link
Copy Markdown

Cherry-picked this over the v4.10.2 tag, seems to work well in my short testing of it. Anything blocking this from being merged?

@LeaPhant
LeaPhant force-pushed the large-url-preview branch 2 times, most recently from 966688d to 4bc4e10 Compare February 23, 2026 14:11

@ajbura ajbura left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ajbura
ajbura merged commit 7570a84 into cinnyapp:dev Mar 14, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants