Repository navigation
Fix bug when calculating if steps fit into scale as a whole number th… - #3685
Merged
Merged
Conversation
Tarqwyn
force-pushed
the
floating_point_bug
branch
2 times, most recently
from
December 6, 2016 15:32
8249534 to
8f73bd2
Compare
…en smal floating point errors make the consition pass false
Tarqwyn
force-pushed
the
floating_point_bug
branch
from
December 7, 2016 09:29
8f73bd2 to
19d26ac
Compare
etimberg
approved these changes
Dec 8, 2016
etimberg
left a comment
etimberg
left a comment
Member
There was a problem hiding this comment.
I think this is fine. CC @chartjs/maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error where if
generationOptions.maxorgenerationOptions.minis calculated to an almost whole number (ie 9.999) then we display the number as 10 on the scale, but calculating an evenly spaced scale is not possible (eg stepSize is 2) as the check fails.By applying an almost whole check we are able to mitigate for FP arithmetic inconsistencies that would cause this behaviour
Please consider the following before submitting a pull request:
Guidelines for contributing: https://github.com/chartjs/Chart.js/blob/master/CONTRIBUTING.md
Example of changes on an interactive website such as the following: