Repository navigation
verify: fix segfault in timedout teardown - #2081
Merged
Merged
Conversation
Fix segfault happening in the teardown caseud by `--trigger-timeout=` option regardless to the --verify= and --verify_state_save= options. `td->inflight_numberio` array is allocated in `init_inflight_logging()` only if ``td->o.verify != VERIFY_NONE && td->o.verify_state_save``. But, in case where those two options are not given and --trigger-timeout= is given and the timer is expired, verify state is attempted to be saved. In this case, `td->inflight_numberio` array is NULL causing the segfault. This patch fixed the segfault by checking `td->inflight_numberio` before assigning them to the state. This can be reproduced with --trigger-timeout= where the device ignores the incoming commands by not issuig the completion simply with QEMU; dm-flakey does not support to ignore the completion itself yet. Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix segfault happening in the teardown caseud by
--trigger-timeout=option regardless to the --verify= and --verify_state_save= options.td->inflight_numberioarray is allocated ininit_inflight_logging()only iftd->o.verify != VERIFY_NONE && td->o.verify_state_save. But, in case where those two options are not given and --trigger-timeout= is given and the timer is expired, verify state is attempted to be saved. In this case,td->inflight_numberioarray is NULL causing the segfault. This patch fixed the segfault by checkingtd->inflight_numberiobefore assigning them to the state.This can be reproduced with --trigger-timeout= where the device ignores the incoming commands by not issuig the completion simply with QEMU; dm-flakey does not support to ignore the completion itself yet.