Repository navigation
Attach the MPS control daemon health gate to MPS tasks - #5119
Merged
Merged
Conversation
harishxr
force-pushed
the
harishxr/mps-daemon-gate-wiring
branch
2 times, most recently
from
September 1, 2026 15:40
e2ee2c5 to
0c4464e
Compare
harishxr
marked this pull request as ready for review
September 1, 2026 17:38
amogh09
previously approved these changes
Sep 1, 2026
harishxr
force-pushed
the
harishxr/mps-daemon-gate-wiring
branch
from
September 1, 2026 20:54
0c4464e to
dfb31b1
Compare
prateekchaudhry
approved these changes
Sep 1, 2026
harishxr
enabled auto-merge (rebase)
September 1, 2026 21:30
amogh09
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the MPS control daemon health gate onto MPS tasks. The gate resource landed in #5107, but nothing created it for a task. This PR attaches one MPSDaemonResource per MPS task and makes every MPS container wait for it before it can be created.
Implementation details
initializeMPSDaemonResource(agent/api/task/task.go) runs inPostUnmarshalTask, right afteraddGPUResource. If any container in the task uses MPS, it creates the resource viaNewMPSDaemonResource, adds it to the task, and makes each MPS container'sContainerCreatedtransition depend on the resource reachingMPSDaemonCreated. So a daemon that is not serving blocks the task at container creation instead of letting a container start with aCUDA_MPS_PINNED_DEVICE_MEM_LIMITthat would be silently ignored. Tasks with no MPS container get no resource , and non-MPS containers in a mixed task are not gated.Testing
New tests cover the changes: yes
Description for the changelog
Enhancement - Attach the MPS control daemon health gate to MPS tasks
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.