Repository navigation
Regenerate ACS model for GPU sharingStrategy and validate it - #5071
Merged
Merged
Conversation
prateekchaudhry
approved these changes
Jul 29, 2026
mye956
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the agent's ACS model to carry the new GPU sharingStrategy on container resourceRequirements, and adds a validator that enforces the strategy is well-formed before a task is acted on. This change lets the agent receive MPS GPU-sharing config.
Implementation details
ecs-agent/acs/model/api/api-2.json- adds resourceRequirements to Container plus four shapes mirroring the upstream model: ResourceRequirementList, ResourceRequirement (value, type, sharingStrategy), SharingStrategy, and NvidiaMpsAllocation (memory required, maxComputePercent optional).ecs-agent/acs/model/ecsacs/api.go- regenerated from the model via go generate; re-vendored into agent/.agent/api/task/task.go- validateResourceRequirements(acsTask), called from TaskFromACS alongside the existing attachment validation. Upstream, sharingStrategy is a union (exactly one member), but the agent's ACS model is generated by the aws-sdk-go v1 generator, which has no union type and emits a plain struct with optional members. An empty strategy, an unknown future strategy (its member dropped on unmarshal), or a missing required field would otherwise deserialize silently and be misread as a whole-GPU request. The validator re-imposes the union guarantee at the point wire data enters the agent. Exactly one known strategy with its required fields, or the task payload is rejected. It reads the wire acsTask directly and mirrors the existing addGPUResource validation style.Testing
New tests cover the changes: yes
Description for the changelog
Enhancement - Regenerate ACS model for GPU sharingStrategy and validate it
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
NoDoes this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.