Repository navigation
feat(acs-model): Add LogDriverVolumeConfiguration to ACS Volume shape - #5005
Merged
Merged
Conversation
aaithal
force-pushed
the
logdriver-volume-configuration
branch
5 times, most recently
from
June 11, 2026 22:24
da0b7dc to
bf0737b
Compare
aaithal
force-pushed
the
logdriver-volume-configuration
branch
from
June 12, 2026 00:07
bf0737b to
80a72d6
Compare
amogh09
approved these changes
Jun 12, 2026
singholt
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
LogDriverVolumeConfigurationstructure andlogDriverVolumeConfigurationfield to the ACSVolumeshape. AddLogDriverOutputto theVolumeTypeenum.Implementation details
ecs-agent/acs/model/api/api-2.json: Added the new shape definition and volume memberecs-agent/acs/model/ecsacs/api.go: Regenerated from the updated model JSONTesting
Downstream consumer builds and passes unit tests with these model additions.
New tests cover the changes: no (model-only change; downstream tests validate consumption)
Description for the changelog
Feature - Add LogDriverVolumeConfiguration to ACS volume model
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No, additive only.
Does this PR include the addition of new environment variables in the README?
No.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.