Repository navigation
Add IsolatedDebugPlatform with DNS field backfill - #4998
Merged
Merged
Conversation
When the ACS payload omits DomainNameServers, netlib copies the host's resolv.conf but leaves the interface struct fields empty. Introduce an IsolatedDebugPlatform that overrides CreateDNSConfig to parse the copied resolv.conf back into the interface fields so the model reflects the DNS config that containers actually use. The backfill is scoped to the isolated debug platform.
willmyrs
force-pushed
the
backfill-dns-debug
branch
from
June 10, 2026 18:12
126d2f1 to
690f57d
Compare
xxx0624
approved these changes
Jun 10, 2026
ShelbyZ
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the ACS payload omits DomainNameServers, netlib copies the host's resolv.conf into the task volume but leaves the interface struct fields empty. This adds an IsolatedDebugPlatform that parses the copied resolv.conf back into the interface fields so the model reflects the DNS config that containers actually use. The backfill is scoped to the isolated debug platform.
Implementation details
Add a new
IsolatedDebugPlatformconstant andisolatedDebugstruct that embedscontainerd. ItsCreateDNSConfigmethod delegates tocreateDNSConfig, then—when the primary interface has noDomainNameServers—reads the resolv.conf that was just copied and backfills the interface fields.The parser (
parseResolvConf) is added tocommon_linux.goand follows resolv.conf(5) using the same rules as Go'snet.dnsReadConfig:;or#are commentsnameservercontributes one IP per linesearchdirective winsThe platform factory in
NewPlatformroutesIsolatedDebugPlatformto the new struct.Testing
Unit tests for
parseResolvConfcovering:New tests cover the changes: yes
Description for the changelog
Enhancement - Add IsolatedDebugPlatform with DNS field backfill from host resolv.conf
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No. This adds a new platform type.
DomainNameServersandDomainNameSearchListare[]stringwithjson:",omitempty"— consumers already handle both nil and populated cases.Does this PR include the addition of new environment variables in the README?
No.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.