Repository navigation
Fix flaky TestDPEAndACSConnFailureTrackerTracking nil pointer panic - #4993
Merged
Merged
Conversation
The test's session struct was missing backoff and timeout fields, causing a nil pointer dereference when the backoff reset timer fired in a separate goroutine during the success test case.
danehlim
approved these changes
Jun 5, 2026
mye956
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky
TestDPEAndACSConnFailureTrackerTrackingthat intermittently panics with nil pointer dereference in CI.Implementation details
The test's session struct was missing
backoffand timeout fields. In the "DPE success and ACS connect success" subcase,startSessionOncereachesstartACSSession, which creates abackoffResetTimerviatime.AfterFunc(AddJitter(s.heartbeatTimeout, s.heartbeatJitter), ...). With both timeout fields at zero, the timer fires immediately in a separate goroutine. If that goroutine runs before the deferredcancel(), it callss.backoff.Reset()on a nil pointer — crashing the test binary.The fix adds
heartbeatTimeout,heartbeatJitter,disconnectTimeout,disconnectJitter, andbackoffto the session struct in the test, matching the pattern used by all other tests in the file.Testing
-count=500(hit within ~100 iterations)-racedetectorNew tests cover the changes: no (this fixes an existing test)
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.