Repository navigation
Add FailureTracker for DiscoverPollEndpoint + ACS/TCS connect workflows - #4983
Merged
Merged
Conversation
danehlim
force-pushed
the
dpe-acs-tcs-connect-fail-track
branch
from
May 29, 2026 00:23
5b5f219 to
454ddd9
Compare
singholt
reviewed
May 29, 2026
danehlim
force-pushed
the
dpe-acs-tcs-connect-fail-track
branch
from
May 29, 2026 22:01
454ddd9 to
aa49367
Compare
danehlim
force-pushed
the
dpe-acs-tcs-connect-fail-track
branch
from
May 29, 2026 23:11
aa49367 to
2d2d650
Compare
singholt
approved these changes
Jun 1, 2026
mye956
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add to the ecs-agent module a new type
FailureTracker, which is used to:Use this new type to monitor failures in:
Implementation details
FailureTrackerand its functionsFailureTracker, record success upon each successful operation and record failure upon each terminal failure modeFailureTrackerto structs which manage callingDiscoverPollEndpointECS API, connecting to ACS, and connecting to TCS (making supplyingFailureTrackeroptional by design)Out of scope
The following is out of scope of this pull request:
FailureTrackerwhen initializing its ACS session and TCS session and kick off metric emission logicWithDPEFailureTracker,WithACSConnFailureTracker, andWithTCSConnFailureTrackerecs-agent/metrics/constants.gowhich may contain overlap with the newly addedDPEConnectivityFailure,ACSConnectivityFailure, andTCSConnectivityFailureTesting
New tests cover the changes: yes
Description for the changelog
N/A
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.