Repository navigation
Feature - Add support for ECS S3 Files integration - #4962
Merged
Merged
Conversation
amogh09
reviewed
May 15, 2026
amogh09
reviewed
May 15, 2026
amogh09
reviewed
May 15, 2026
rsu206
force-pushed
the
s3files
branch
2 times, most recently
from
May 19, 2026 22:33
6004445 to
98dbb8c
Compare
amogh09
previously approved these changes
May 20, 2026
ShelbyZ
reviewed
May 20, 2026
Contributor
|
Contributor
Author
|
New MACIS tests passed in preprod: |
ShelbyZ
approved these changes
May 27, 2026
amogh09
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds S3 Files volume support to the ECS Agent. It enables tasks to mount S3-backed file systems as NFS volumes via the ECS volume plugin, following the same architectural pattern used for EFS volumes. The agent advertises the storage.s3-files capability, receives S3 Files volume attachments from ACS, converts them into volume definitions using the ECS volume plugin, and manages their lifecycle with proper task-network dependencies.
Implementation details
New Attachment Type & Constants (ecs-agent/api/attachment/resource/)
S3FilesAccessPointIdKey.
S3 Files Volume Configuration (agent/taskresource/volume/dockervolume_s3files.go)
awscredsuri, and optionally tlsport and accesspoint.
ACS Payload Handling (agent/acs/session/payload_responder.go)
Task Attachment Handler (agent/api/task/task_attachment_handler.go)
pre-existing placeholder volume with the same name.
Volume Initialization (agent/api/task/task.go)
plugin with the driver options, registers it as a task resource, and sets up container volume dependencies.
Task Volume Serialization (agent/api/task/taskvolume.go)
Docker Volume Resource (agent/taskresource/volume/dockervolume.go)
the S3FilesVolumeType.
Agent Capability (agent/app/agent_capability*.go)
ECS Volume Plugin (ecs-init/volumes/ecs_volume_plugin.go)
Testing
This was tested manually on an EC2 instance. See following logs
New tests cover the changes:
New tests passed in preprod:
Description for the changelog
Feature - Add support for ECS S3 Files integration
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.