Skip to content

Use env variable to read user input when mounting FSx volumes - #4934

Merged
sparrc merged 1 commit into
aws:devfrom
KlwntSingh:fsx-windows-bug-fix
Apr 21, 2026
Merged

sparrc merged 1 commit into
aws:devfrom
KlwntSingh:fsx-windows-bug-fix

Conversation

@KlwntSingh

Copy link
Copy Markdown
Contributor

Summary

This change uses env variable to read user input when mounting FSx volumes. This removes the custom logic for allowing special characters in password.

Testing

  1. Tested the change if FSx still works on all 2019, 2022, 2025 - PASS
  2. Tested using special characters in password, this work as expected i.e. special password was still allowed.
  3. I have added 2 new unit tests for above use-cases. They are green.

New tests cover the changes: yes

Format: [Category] Description
Categories: Feature, Enhancement, Bugfix, Housekeeping

This is a bug fix.

Examples:

  • Feature - Add support for ECS Exec
  • Enhancement - Improve error handling in task cleanup
  • Bugfix - Fixed memory leak in stats collector
  • Housekeeping - Update go module dependencies

You can see our changelog entry style here:
c9aefeb
-->

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@KlwntSingh
KlwntSingh requested a review from a team as a code owner April 20, 2026 17:12
@KlwntSingh KlwntSingh changed the title Fsx Windows bug fix: Use env to read user input when mounting FSx volumes Fsx bug fix: Use env variable to read user input when mounting FSx volumes Apr 20, 2026
@KlwntSingh KlwntSingh changed the title Fsx bug fix: Use env variable to read user input when mounting FSx volumes Use env variable to read user input when mounting FSx volumes Apr 20, 2026
amogh09
amogh09 previously approved these changes Apr 20, 2026
sparrc
sparrc previously approved these changes Apr 20, 2026
@KlwntSingh
KlwntSingh changed the base branch from master to dev April 20, 2026 20:20
@KlwntSingh
KlwntSingh dismissed stale reviews from sparrc and amogh09 April 20, 2026 20:20

The base branch was changed.

@sparrc
sparrc merged commit 09f274e into aws:dev Apr 21, 2026
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants