Repository navigation
Replace ssm endpoint resolution logic with UseDualStackEndpoint - #4931
Merged
Merged
Conversation
TheanLim
force-pushed
the
ssmUseDualStack
branch
from
April 14, 2026 22:06
7fe6621 to
a351721
Compare
TheanLim
force-pushed
the
ssmUseDualStack
branch
from
April 15, 2026 18:35
a351721 to
1dbfa83
Compare
TheanLim
force-pushed
the
ssmUseDualStack
branch
from
April 15, 2026 19:27
1dbfa83 to
564a11a
Compare
TheanLim
changed the title
mye956
reviewed
Apr 16, 2026
mye956
previously approved these changes
Apr 16, 2026
amogh09
reviewed
Apr 16, 2026
Contributor
|
Does |
TheanLim
force-pushed
the
ssmUseDualStack
branch
from
April 17, 2026 18:52
564a11a to
208c864
Compare
amogh09
approved these changes
Apr 17, 2026
mye956
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace per-service dualstack endpoint resolution with aws-ssm-agent's built-in
UseDualStackEndpointconfig flag for IPv6-only ECS Exec support.Implementation details
UseDualStackEndpointin the SSM agent config based on IPv6-only detection.endpointImpl.GetServiceEndpoint()(endpoint), then override only if the config'sEndpointfield is non-empty. With dual-stack enabled, the auto-resolved values match the previous per-service dualstack endpoint resolution.Mgs.Region,Mgs.Endpoint,Agent.Region,Agent.OrchestrationRootDir) — empty strings already trigger auto-resolution.StopTimeoutMillis(20000) for visibility even though it matches the default.endpointspackageendpoint_suffixcode inecs-anywhere-install.sh.Testing
TestFormatSSMAgentConfig,TestGetExecAgentConfigFileName) to match the new SSM Agent config template.New tests cover the changes: no
Description for the changelog
Enhancement - Replace SSM Dualstack endpoint resolution logic with UseDualStackEndpoint
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.