Repository navigation
Add NeuronDevices type and sysfs-based device discovery - #4919
Merged
Merged
Conversation
pengubco
reviewed
Apr 8, 2026
pengubco
previously approved these changes
Apr 8, 2026
Add device-level discovery alongside existing core-based discovery in the shared neuron utils package. This supports the pivot from neuron cores to neuron devices as the resource unit for ECS Managed Instances. - NeuronDevices struct with DeviceByID() and DeviceIDs() methods - DiscoverDevices() enumerates /sys/class/neuron_device/neuron*, validates /dev/neuronX exists, skips non-numeric entries - Tests for discovery, missing device files, non-device sysfs entries - Existing core-based types and functions are unchanged
mye956
reviewed
Apr 8, 2026
mye956
reviewed
Apr 8, 2026
mye956
approved these changes
Apr 8, 2026
prateekchaudhry
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add device-level Neuron discovery in the shared neuron utils package.
Implementation details
NeuronDevicesstruct withDeviceByID()andDeviceIDs()methods inecs-agent/utils/neuron/neuron.goDiscoverDevices()inecs-agent/utils/neuron/neuron_linux.go— enumerates/sys/class/neuron_device/neuron*, validates/dev/neuronXexists, skips non-numeric sysfs entriesTesting
DiscoverDevices(): no devices, single device, multiple devices, missing device file, non-device sysfs entriesNeuronDevicesmethods:DeviceIDs()(nil, empty, populated),DeviceByID()(found, not found)New tests cover the changes: yes
Description for the changelog
Enhancement - Add device-level Neuron discovery utils to shared library
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.