Repository navigation
Use resolv.conf from host for Service Connect tasks on ECS managed instnaces - #4849
Merged
Merged
Conversation
xxx0624
force-pushed
the
dev
branch
2 times, most recently
from
January 23, 2026 20:27
8fc4fa3 to
7fb7b13
Compare
xxx0624
changed the title
xxx0624
marked this pull request as ready for review
January 23, 2026 22:11
amogh09
approved these changes
Jan 24, 2026
| if err != nil { | ||
| return errors.Wrap(err, "unable to create hostname file for netns") | ||
| } | ||
| err = m.createHostnameFileForDefaultNetNS() |
Contributor
There was a problem hiding this comment.
Question - why is this needed?
Contributor
Author
There was a problem hiding this comment.
It's copied from here although I can't think of any case where the file is missing. To be safe, I just added it. It will do nothing if it exists.
This was referenced Jan 29, 2026
Merged
alexcmms
pushed a commit
to alexcmms/amazon-ecs-agent
that referenced
this pull request
Jan 30, 2026
alexcmms
pushed a commit
to alexcmms/amazon-ecs-agent
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is use force Service Connect/SC tasks on ECS Managed Instances to use /etc/resolv.conf from the host because Control Plane won't send down this information. Which is same as ECS on EC2.
Implementation details
Copy /etc/resolv.conf from host to SC tasks.
Testing
New tests cover the changes:
Yes
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.