Repository navigation
Fix agent update on ipv6-only instances - #4781
Merged
Merged
Conversation
amogh09
force-pushed
the
ipv6-update-agent
branch
from
September 16, 2025 17:04
28d29bf to
617165b
Compare
amogh09
force-pushed
the
ipv6-update-agent
branch
from
September 16, 2025 17:04
617165b to
be5e491
Compare
amogh09
marked this pull request as ready for review
September 16, 2025 17:05
Yiyuanzzz
approved these changes
Sep 16, 2025
mye956
approved these changes
Sep 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a bug in agent update (UpdateContainerAgent API) handling for IPv6-only instances. The update location (S3 URL) streamed down to Agent is currently not IPv6 compatible, so as a temporary workaround, Agent needs to convert it to IPv6-only compatible (dualstack) S3 URL.
Legacy S3 URLs have format -
Dualstack S3 URLs have format -
so, the conversion is rather simple and works for all partitions.
Testing
I made some temporary changes to make Agent think that it's running v1.98.0 with its corresponding build ID. Then I ran that Agent on an IPv6-only instance and called UpdateContainerAgentAPI on it. Update was successful.
Agent logs -
Introspection before/after -
New tests cover the changes: yes
Description for the changelog
bugfix: Fix agent update handling for IPv6-only instances
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.