Repository navigation
AKS/GKE OTel Container Insights parity with helm - #2283
Merged
Merged
Conversation
Paamicky
force-pushed
the
mcommey/helm-agent-parity
branch
from
September 10, 2026 19:22
be3d1a9 to
503516e
Compare
Paamicky
force-pushed
the
mcommey/helm-agent-parity
branch
from
September 10, 2026 20:40
503516e to
48e07d0
Compare
Contributor
Binary Size Reportlinux/amd64
Notable changes:
linux/arm64
windows/amd64
Investigating size changesUse go-size-analyzer to compare binaries: GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary> |
lorespiz
approved these changes
Sep 24, 2026
bhavya76
approved these changes
Sep 24, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
When OTel Container Insights runs on AKS/GKE, the agent didn't fully reproduce the config the Helm chart used to pre-render: the apiserver scrape lacked TLS
server_name, and node-VM identity attributes (azure.vm.*) leaked onto cluster-scoped metrics.Description of changes
server_name=kubernetes.default.svcfor AKS/GKE managed control planes (their cert SAN doesn't match the scraped IP).azure.vm.*on cluster-scoped Container Insights metrics.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added
TestContainerInsightsAKSGKEConfig(AKS + GKE cluster goldens) and updated existing goldens.go build ./...andgo test ./translator/tocwconfig/...pass.Requirements
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.