Skip to content

AKS/GKE OTel Container Insights parity with helm - #2283

Merged
Paamicky merged 9 commits into
mainfrom
mcommey/helm-agent-parity
Sep 24, 2026
Merged

Paamicky merged 9 commits into
mainfrom
mcommey/helm-agent-parity

Conversation

@Paamicky

Copy link
Copy Markdown
Contributor

Description of the issue

When OTel Container Insights runs on AKS/GKE, the agent didn't fully reproduce the config the Helm chart used to pre-render: the apiserver scrape lacked TLS server_name, and node-VM identity attributes (azure.vm.*) leaked onto cluster-scoped metrics.

Description of changes

  • Set apiserver TLS server_name=kubernetes.default.svc for AKS/GKE managed control planes (their cert SAN doesn't match the scraped IP).
  • Suppress azure.vm.* on cluster-scoped Container Insights metrics.
  • Add AKS/GKE cluster golden tests locking in both behaviors.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Added TestContainerInsightsAKSGKEConfig (AKS + GKE cluster goldens) and updated existing goldens. go build ./... and go test ./translator/tocwconfig/... pass.

Requirements

  1. Run make fmt and make fmt-sh
  2. Run make lint

Integration Tests

To run integration tests against this PR, add the ready for testing label.

@Paamicky
Paamicky force-pushed the mcommey/helm-agent-parity branch from be3d1a9 to 503516e Compare September 10, 2026 19:22
@Paamicky Paamicky added the ready for testing Indicates this PR is ready for integration tests to run label Sep 10, 2026
@Paamicky Paamicky changed the title Mcommey/helm agent parity AKS/GKE OTel Container Insights parity with helm. Sep 10, 2026
@Paamicky
Paamicky force-pushed the mcommey/helm-agent-parity branch from 503516e to 48e07d0 Compare September 10, 2026 20:40
@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Binary Size Report

linux/amd64

Binary PR vs main (d727897) vs v1.300073.0
amazon-cloudwatch-agent 236.6 MB ${\color{red}▲}$ +4.1 KB (+0.0%) ${\color{red}▲}$ +41.7 MB (+21.4%)
amazon-cloudwatch-agent-config-wizard 2.0 MB +0 B +0 B
config-downloader 2.0 MB +0 B +0 B
config-translator 2.0 MB +0 B +0 B
start-amazon-cloudwatch-agent 2.5 MB +0 B +0 B
workload-discovery 3.0 MB +0 B +0 B
Total 248.1 MB ${\color{red}▲}$ +4.1 KB (+0.0%) ${\color{red}▲}$ +41.7 MB (+20.2%)
linux/amd64 amazon-cloudwatch-agent (last 9 main commits + this PR)

 239 ┤                                        
     ┤                            ███ ███ ███ 
     ┤                            ███ ███ ███ 
     ┤                            ███ ███ ███ 
     ┤                            ███ ███ ███ 
     ┤                            ███ ███ ███ 
     ┤                            ███ ███ ███ 
     ┤                            ███ ███ ███ 
 193 ┤▄▄▄ ▄▄▄ ▄▄▄ ▄▄▄ ▄▄▄ ▄▄▄ ▄▄▄ ███ ███ ███ 
 MB  └────────────────────────────────────────
      3262v1.300073.0                     PR

Notable changes:

linux/arm64
Binary PR vs main (d727897) vs v1.300073.0
amazon-cloudwatch-agent 214.4 MB +0 B ${\color{red}▲}$ +35.8 MB (+20.0%)
amazon-cloudwatch-agent-config-wizard 2.0 MB +0 B +0 B
config-downloader 2.0 MB +0 B +0 B
config-translator 2.0 MB +0 B +0 B
start-amazon-cloudwatch-agent 2.4 MB +0 B +0 B
workload-discovery 2.9 MB +0 B +0 B
Total 225.6 MB +0 B ${\color{red}▲}$ +35.8 MB (+18.8%)
windows/amd64
Binary PR vs main (d727897) vs v1.300073.0
amazon-cloudwatch-agent.exe 240.1 MB ${\color{red}▲}$ +6.7 KB (+0.0%) ${\color{red}▲}$ +42.5 MB (+21.5%)
amazon-cloudwatch-agent-config-wizard.exe 2.1 MB +0 B +0 B
config-downloader.exe 2.1 MB +0 B +0 B
config-translator.exe 2.1 MB +0 B +0 B
start-amazon-cloudwatch-agent.exe 2.3 MB +0 B +0 B
workload-discovery.exe 3.1 MB +0 B ${\color{red}▲}$ +192.5 KB (+6.6%)
Total 251.9 MB ${\color{red}▲}$ +6.7 KB (+0.0%) ${\color{red}▲}$ +42.7 MB (+20.4%)
Investigating size changes

Use go-size-analyzer to compare binaries:

GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary>

@Paamicky
Paamicky marked this pull request as ready for review September 11, 2026 19:22
@Paamicky
Paamicky requested a review from a team as a code owner September 11, 2026 19:22
@Paamicky Paamicky changed the title AKS/GKE OTel Container Insights parity with helm. AKS/GKE OTel Container Insights parity with helm Sep 24, 2026
@Paamicky
Paamicky merged commit 92213f4 into main Sep 24, 2026
507 of 513 checks passed
@Paamicky
Paamicky deleted the mcommey/helm-agent-parity branch September 24, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for testing Indicates this PR is ready for integration tests to run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants