Repository navigation
nbbuild: upgrade sigtest-maven-plugin from 2.3 to 2.7 - #9594
Conversation
|
@mbien it looks hard, I tried to resign but look like the binaryclass contain type like 0x60 and other that is not related to any possible type listed in the sigtest plugin. |
|
master has a similar exception: PR:
we really have to get the logging under control and only log the interesting stuff, even simple steps produce thousands of lines. |
|
netbeans/ide/libs.c.kohlschutter.junixsocket/build.xml Lines 25 to 42 in e11f44b |
|
it looks like some lib wrappers which failed on validation were configured with Solution is relatively simple: lets disable sigtest for lib wrappers which were previously marked with fail-on-error false entirely, and we should be able to upgrade. Tested via #9620 We can move the commit over to this PR later, once reviewed so that everything is at the right PR. IMO: we should also reconsider if sigtesting third party libs is worth the effort, it creates just noise, huge diffs and is likely of little value for anyone. |
disable sig tests on lib wrappers which ignored verification errors already. (sigtest.gen.fail.on.error=false becomes sigtest.skip.gen=true) jakarta.tck:sigtest-maven-plugin:2.7 fails there in a way which can't be ignored anymore. Co-authored-by: Michael Bien <mbien42@gmail.com>
sigtest.gen.fail.on.error=falsebecomessigtest.skip.gen=true)jakarta.tck:sigtest-maven-plugin:2.7fails there in a way which can't be ignored anymore.removed the jsoup update on this pr