Skip to content

lsp.client: Result of textDocument/documentHighlight can be null - #8640

Merged
matthiasblaesing merged 1 commit into
apache:masterfrom
matthiasblaesing:gh-8639
Jul 11, 2025
Merged

matthiasblaesing merged 1 commit into
apache:masterfrom
matthiasblaesing:gh-8639

Conversation

@matthiasblaesing

@matthiasblaesing matthiasblaesing commented Jul 8, 2025 •

Copy link
Copy Markdown
Contributor

According to LSP specification 3.17, the call to textDocument/documentHighlight may yield a null vale:

Response:

result: DocumentHighlight[] | null

Closes: #8639

According to LSP specification 3.17, the call to
textDocument/documentHighlight may yield a null vale:

Response:

    result: DocumentHighlight[] | null
@matthiasblaesing matthiasblaesing added this to the NB27 milestone Jul 8, 2025
@matthiasblaesing matthiasblaesing added LSP [ci] enable Language Server Protocol tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 8, 2025

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lahodaj lahodaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@matthiasblaesing

Copy link
Copy Markdown
Contributor Author

Thanks for review.

@matthiasblaesing
matthiasblaesing merged commit 857d8f3 into apache:master Jul 11, 2025
@matthiasblaesing
matthiasblaesing deleted the gh-8639 branch July 16, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) LSP [ci] enable Language Server Protocol tests

Projects

None yet

3 participants