Repository navigation
feat(update_replication_factor#11): add max_reserved_dropped_replicas into server config file - #999
Merged
levy5307 merged 1 commit intoJun 10, 2022
Conversation
β¦ to server config file
acelyc111
approved these changes
Jun 8, 2022
acelyc111
requested review from
Smityz,
foreverneverer,
hycdong,
levy5307 and
neverchanje
June 9, 2022 03:18
levy5307
approved these changes
Jun 10, 2022
acelyc111
added
the
type/config-change
11 tasks done
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subtask of #865.
Firstly, for details about
max_reserved_dropped_replicasplease see XiaoMi/rdsn#1109.As is described in XiaoMi/rdsn#1109, cluster-level
max_replicas_in_grouphas been replaced withmax_reserved_dropped_replicas. To be consistent withmax_replicas_in_group,max_reserved_dropped_replicasshould be set to 0 for production environments. It should be added into server config file and set to 0.[meta_server] + max_reserved_dropped_replicas = 0