Skip to content

Fix write global seqno - #1563

Merged
empiredan merged 3 commits into
apache:masterfrom
ruojieranyishen:fix_write_global_seqno
Jul 11, 2023
Merged

empiredan merged 3 commits into
apache:masterfrom
ruojieranyishen:fix_write_global_seqno

Conversation

@ruojieranyishen

@ruojieranyishen ruojieranyishen commented Jul 7, 2023 •

Copy link
Copy Markdown
Collaborator

#1562

Add this option to turn off rocksdb modifying rocksdb.external_sst_file.global_seqno
field of external sst file during ingest process. This is used to address a coredump
caused by incorrect field value in RocksDB. This pull request fixs the bug above.
Rocksdb 6.6.4 no longer recommends using this field.

New configuration is added:

[pegasus.server]
+ rocksdb_write_global_seqno = false

โ€ฆo false by default. apache#1560

apache#1560

Add rocksdb_write_global_seqno, and set its default value to false.
โ€ฆefault. apache#1562

apache#1562

Add rocksdb_write_global_seqno, and set its default value to false.
@github-actions github-actions Bot added the cpp label Jul 7, 2023
@hycdong hycdong added the type/config-change Added or modified configuration that should be noted on release note of new version. label Jul 10, 2023
@hycdong

hycdong commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

This pull request adds a new configuration, please add it into your pr description like the old one: XiaoMi/rdsn#851

@empiredan
empiredan merged commit 99456f4 into apache:master Jul 11, 2023
@empiredan empiredan mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp type/config-change Added or modified configuration that should be noted on release note of new version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants