Skip to content

feat(Ranger): Compatible with the old ACL and the new ACL - #1379

Merged
empiredan merged 2 commits into
apache:masterfrom
WHBANG:ranger_access_contoller
Mar 9, 2023
Merged

feat(Ranger): Compatible with the old ACL and the new ACL#1379
empiredan merged 2 commits into
apache:masterfrom
WHBANG:ranger_access_contoller

Conversation

@WHBANG

@WHBANG WHBANG commented Mar 1, 2023 •
edited by empiredan
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

#1054

This patch is compatible with old and new acl.

  • Modify some method names and parameter names to make them more accurate.
  • Defines the configuration parameters that the new ACL needs to use.
  • Two new 'allowed()' methods are provided for meta_server and replica_server.
  • Some incompatible methods will be removed, (allowed&pre_check)commented.

New configuration is added:

[security]
+ enable_ranger_acl = false

@github-actions github-actions Bot added the cpp label Mar 1, 2023
acelyc111
acelyc111 reviewed Mar 2, 2023
View reviewed changes
Comment thread src/runtime/security/access_controller.cpp Resolved
Comment thread src/runtime/security/access_controller.cpp Resolved
Comment thread src/runtime/security/access_controller.cpp Resolved
Comment thread src/runtime/security/access_controller.cpp Resolved
Comment thread src/runtime/security/access_controller.h Resolved
acelyc111
acelyc111 reviewed Mar 3, 2023
View reviewed changes
Comment thread src/runtime/security/access_controller.h Resolved
@WHBANG WHBANG changed the title feat(security): Use Apache Ranger for access control(4/n) feat(security): compatible with old and new acl(4/n) Mar 3, 2023
@WHBANG WHBANG changed the title feat(security): compatible with old and new acl(4/n) feat(security): compatible with old and new ACL(4/n) Mar 3, 2023
@WHBANG
WHBANG force-pushed the ranger_access_contoller branch from 3d5f5bf to 46b9450 Compare March 3, 2023 12:23
@WHBANG WHBANG changed the title feat(security): compatible with old and new ACL(4/n) feat(security): Compatible with the old ACL and the new ACL(4/n) Mar 3, 2023
@acelyc111 acelyc111 changed the title feat(security): Compatible with the old ACL and the new ACL(4/n) feat(Ranger): Compatible with the old ACL and the new ACL Mar 6, 2023
acelyc111
acelyc111 approved these changes Mar 6, 2023
View reviewed changes
Comment thread src/runtime/security/access_controller.cpp Resolved
@empiredan
empiredan merged commit 84ce5fb into apache:master Mar 9, 2023
@empiredan empiredan mentioned this pull request Aug 21, 2023
Closed
@empiredan empiredan added the type/config-change Added or modified configuration that should be noted on release note of new version. label Nov 29, 2023
GehaFearless pushed a commit to GehaFearless/incubator-pegasus that referenced this pull request Feb 28, 2024
赖迎春
[SKV-627] feat(Ranger): Compatible with the old ACL and the new ACL (a…
53e5a22 
…pache#1379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@empiredan empiredan empiredan approved these changes
@acelyc111 acelyc111 acelyc111 approved these changes

Assignees

No one assigned

Labels

cpp type/config-change Added or modified configuration that should be noted on release note of new version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WHBANG @empiredan @acelyc111