Skip to content

fix(go-client): scan will not recover when encounter error_invalid_state - #1106

Merged
foreverneverer merged 4 commits into
apache:masterfrom
foreverneverer:fix-scan
Aug 8, 2022
Merged

foreverneverer merged 4 commits into
apache:masterfrom
foreverneverer:fix-scan

Conversation

@foreverneverer

@foreverneverer foreverneverer commented Aug 8, 2022 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

#903

If rpc's resp = error_invalid_state, go client should support re-config, which support most api but not scan in the past

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
Code changes
  • Has interface methods change
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@codecov-commenter

codecov-commenter commented Aug 8, 2022 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@b27f101). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1106   +/-   ##
=========================================
  Coverage          ?   53.40%           
=========================================
  Files             ?       27           
  Lines             ?     2522           
  Branches          ?        0           
=========================================
  Hits              ?     1347           
  Misses            ?     1130           
  Partials          ?       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@foreverneverer
foreverneverer marked this pull request as ready for review August 8, 2022 06:37
@foreverneverer
foreverneverer merged commit 6ceb51b into apache:master Aug 8, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants