Repository navigation
fix(go-client): scan will not recover when encounter error_invalid_state - #1106
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
=========================================
Coverage ? 53.40%
=========================================
Files ? 27
Lines ? 2522
Branches ? 0
=========================================
Hits ? 1347
Misses ? 1130
Partials ? 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
foreverneverer
marked this pull request as ready for review
August 8, 2022 06:37
levy5307
approved these changes
Aug 8, 2022
empiredan
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#903
If rpc's resp = error_invalid_state, go client should support re-config, which support most api but not
scanin the pastWhat is changed and how does it work?
nextBatch, but miss instartScanPartition, this pr add it.Checklist
Tests
Code changes
Related changes