Repository navigation
feat: improve performance of count_data - #1091
Merged
Merged
Conversation
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 1, 2022 08:29
42ad016 to
788d2ef
Compare
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 1, 2022 11:12
788d2ef to
12798d8
Compare
empiredan
changed the title
empiredan
reviewed
Aug 2, 2022
GehaFearless
force-pushed
the
lgh_count_data
branch
2 times, most recently
from
August 3, 2022 11:44
f4c5af1 to
1be846c
Compare
acelyc111
reviewed
Aug 4, 2022
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 5, 2022 08:45
1be846c to
d188ff6
Compare
WHBANG
reviewed
Aug 10, 2022
acelyc111
reviewed
Aug 10, 2022
GehaFearless
force-pushed
the
lgh_count_data
branch
3 times, most recently
from
August 11, 2022 03:40
8d2fe21 to
bb901e0
Compare
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 11, 2022 06:35
bb901e0 to
501ce57
Compare
Member
|
Could you give some performance comparation with the old version ? |
acelyc111
reviewed
Aug 13, 2022
GehaFearless
force-pushed
the
lgh_count_data
branch
3 times, most recently
from
August 15, 2022 14:06
2e0e6fd to
dad6442
Compare
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 16, 2022 04:09
dad6442 to
12d1ec6
Compare
acelyc111
reviewed
Aug 17, 2022
acelyc111
reviewed
Aug 18, 2022
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 18, 2022 07:58
456264a to
b0585c3
Compare
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 18, 2022 09:40
b0585c3 to
865586c
Compare
acelyc111
reviewed
Aug 19, 2022
acelyc111
reviewed
Aug 23, 2022
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 23, 2022 07:15
3dbc957 to
f7de899
Compare
GehaFearless
force-pushed
the
lgh_count_data
branch
from
August 23, 2022 08:05
f7de899 to
8de3a44
Compare
acelyc111
previously approved these changes
Aug 24, 2022
empiredan
reviewed
Aug 27, 2022
Co-authored-by: Dan Wang <wangdan@apache.org>
Co-authored-by: Dan Wang <wangdan@apache.org>
Co-authored-by: Dan Wang <wangdan@apache.org>
acelyc111
approved these changes
Aug 30, 2022
empiredan
approved these changes
Aug 30, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
issue: #1090
same job as before: #728
When we precisely count data for a large table, it will cost minutes or hours.
However, it's unnecessarily return key-values from server to client.
What is changed and how does it work?
Actually, we just need the count of data. So we just need transfer the count of data from server to client, but not the detailed data.
In my test, it will 2x on onebox faster than before.
for my bench on onebox๏ผ
1> before
2> this commit
Tests
Related changes