Repository navigation
fix(gauge): fix z2 is negative when maxVal is negative - #20276
Merged
Merged
Conversation
Ovilia
reviewed
Aug 23, 2024
Ovilia
left a comment
Contributor
There was a problem hiding this comment.
I don't think #20097 should be a bug. I commented at #20097 (comment) . Can you have a look, please?
Ovilia
requested changes
Aug 23, 2024
Ovilia
left a comment
Contributor
There was a problem hiding this comment.
It seems that you can use linearMap in src/util/number.ts
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20276@88345fe |
Contributor
Ovilia
approved these changes
Aug 26, 2024
|
Congratulations! Your PR has been merged. Thanks for your contribution! π |
Contributor
Author
Thanks very much for your advice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
When
maxof a gauge is negative, thez2calculated is also negative. Thus the axisLine is on top of the progress bar. This PR fixes howz2is calculated to ensure it is always non-negative.Fixed issues
fix #20097
Details
Before: What was the problem?
The progress bar is beneath the axisLine.
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information