Repository navigation
Make copy, getLgK public in cpc - #38
Merged
Merged
Conversation
freakyzoidberg
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR makes internal functions public by renaming them to follow Go's export conventions, and updates the corresponding tests and references.
- Export getLgK as GetLgK in CpcSketch
- Export copy as Copy in CpcSketch and update its usage in union and test files
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpc/utils_test.go | Updated error message case to match the new public API (GetLgK). |
| cpc/cpc_union.go | Renamed copy() to Copy() when copying sketches, ensuring API consistency. |
| cpc/cpc_sketch_test.go | Changed copy() to Copy() in tests to use the newly exported API. |
| cpc/cpc_sketch.go | Updated method names and comments for getLgK and copy, making them public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.