More sensible FSRS progress indicator precision - #2684
Merged
Merged
Conversation
meliache
force-pushed
the
lower-fsrs-progress-precision
branch
from
September 25, 2023 14:51
3e9922c to
624adc8
Compare
It's very helpful having a sub-permille precision in a progress indicator, percent-precision or at most a tenth of a percent should be sufficient for any indicator. But in particular the compute-retention progress has 10 steps, i.e. the progress increases in 10%-intervals (10%, 20%, ...), it *cannot* have sub-decimal progress-percentages, see https://github.com/open-spaced-repetition/fsrs-rs/blob/2d5b19b4941599b1fbc7a49dbbe89774f975e4ed/src/optimal_retention.rs#L365-L368. So there integer percents should be enough, everything else is misleading. The compute-weights progress is currently (as of beta-2) not showing up at all. Maybe if the bug is fixed it can show sub-percent percentages, so for know I changed that to 0.1% precision. But I think integer percentages should be fine here as well, so upon request I can fix that. Also see my comment on this problem in https://forums.ankiweb.net/t/anki-23-10-beta/34912/39.
meliache
force-pushed
the
lower-fsrs-progress-precision
branch
from
September 25, 2023 14:54
624adc8 to
94bd130
Compare
meliache
changed the title
Member
|
Looks good - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its very helpful having a sub-permille precision in a progress indicator, percent-precision or at most a tenth of a percent should be sufficient for any indicator.
But in particular the compute-retention progress has 10 steps, i.e. the progress increases in 10%-intervals (10%, 20%, ...), it cannot have sub-decimal progress-percentages, see the fsrs-rs
optimal_retentionfunction. So there integer percents should be enough, everything else is misleading.The compute-weights progress is currently (as of beta-2) not showing up at all. Maybe if the bug is fixed it can show sub-percent percentages, so for know I changed that to 0.1% precision. But I think integer percentages should be fine here as well, so upon request I can fix that.
Before:
After:
Also see my comment on this issue in the beta forum thread.