Repository navigation
fix(vllm): [release/1.6.0] shut down EngineCore when a prefill worker exits - #16789
Merged
Merged
Conversation
Signed-off-by: svc-glamr@nvidia.com <svc-glamr@nvidia.com> Signed-off-by: GLAMR <svc-glamr@nvidia.com> (cherry picked from commit 3763cee) Signed-off-by: yunzhoul-nv <232973175+yunzhoul-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick #16401 onto
release/1.6.0to explicitly shut down the vLLM EngineCore when a prefill worker exits.Shares
_WorkerLifecycleacross prefill, decode, and aggregated workers. Includes the upstream regression test and FPM test port-binding adjustment. Based on release commitd94072d69df850d183ce0a98001b0029893f5bb2, with cherry-pick provenance and DCO sign-off.Conflict Resolution
Resolved one import-only conflict in
components/src/dynamo/vllm/tests/test_vllm_worker_factory.py, caused by #15110 (commit9dc820205913655f0b3642d52395b00ab411e361).#15110 added
_benchmark_engine_identityand_benchmark_worker_probe_pathimports adjacent to_DecodeWorkerLifecycleon main. Those helpers are absent fromrelease/1.6.0; #16401 removes the adjacent old lifecycle import and adds_WorkerLifecycle.This backport retains the release branch's imports, removes
_DecodeWorkerLifecycle, and adds_WorkerLifecycle, without bringing in the main-only benchmark helpers. Compared with #16401, only the surrounding import context differs; implementation and test-body changes applied without conflicts. Git range-diff confirms this scope.Evidence
Validation
kill -SIGINT 1case. The cause of the changed exit order in the rc3 image remains unknown.Merge Danger
Door: two-way
Revert the single cherry-pick commit.
Blast Radius: vLLM
Changes worker cleanup and explicitly shuts down EngineCore after prefill exit or startup failure.
Related Issues
Refs DYN-4917 โ https://linear.app/nvidia/issue/DYN-4917
Source PR: #16401