Skip to content

chore(operator): drop stale dynamoGraphDeploymentRef from LPX bindings - #15522

Merged
kathleenfrench merged 1 commit into
mainfrom
kfrench/drop-stale-lpx-dgd-ref
Oct 1, 2026
Merged

kathleenfrench merged 1 commit into
mainfrom
kfrench/drop-stale-lpx-dgd-ref

Conversation

@kathleenfrench

@kathleenfrench kathleenfrench commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Overview:

Removes the stale MaterializationScope.DynamoGraphDeploymentRef field from the operator's generated LPX scheduler bindings, so they match the current LPX scheduler API.

Details:

  • deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.go is generated from the LPX scheduler API (Code generated by lpx-scheduler. DO NOT EDIT.). The scheduler's LpuPipelineRequest status no longer includes materializationScope.dynamoGraphDeploymentRef. This copy predates that removal and still declares the field as required.
  • This PR regenerates the file from the current scheduler API and keeps the repository's SPDX header. The only resulting change removes the field and its DeepCopyInto line; the rest of the generated file is byte-identical.
  • There is no behavior change. Nothing in the operator reads or writes the field outside the generated package, and unknown JSON keys are ignored when decoding scheduler status.
  • Validated in deploy/operator with Go 1.26.6: go build ./..., plus go vet and go test for ./internal/dynamo/lpx/... and ./internal/controller/lpx/....

Where should the reviewer start?

deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.go: the two deleted lines in MaterializationScope and MaterializationScope.DeepCopyInto.

Related Issues

πŸ”— This PR is linked to an issue:

Summary by CodeRabbit

  • Refactor
    • Internal scheduler materialization data no longer includes a deployment reference. Existing references to scheduling components and the replica index remain unchanged. This change does not alter end-user-facing features or behavior.

Regenerate the LPX scheduler API bindings from the current scheduler
API. The scheduler no longer publishes
materializationScope.dynamoGraphDeploymentRef, but this generated copy
predates that removal and still declared it as a required field.

Nothing in the operator reads or writes the field, and unknown JSON keys
are ignored when decoding scheduler status, so behavior is unchanged.

Signed-off-by: kathleen french <kfrench@nvidia.com>
@kathleenfrench
kathleenfrench requested review from a team as code owners October 1, 2026 19:12
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added chore deployment::k8s Relates to dynamo deployment in kubernetes labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack β†’

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Repository: ai-dynamo/dynamo/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bd6ae975-80e5-4828-b752-3782a5b55b2a

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between ec71339 and 056916d.

πŸ“’ Files selected for processing (1)
  • deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.go
πŸ’€ Files with no reviewable changes (1)
  • deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The scheduler API removes DynamoGraphDeploymentRef from MaterializationScope and removes the corresponding deep-copy operation.

Changes

MaterializationScope update

Layer / File(s) Summary
Remove deployment reference
deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.go
MaterializationScope no longer declares DynamoGraphDeploymentRef. Its deep-copy method no longer copies the field.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: βšͺ Minimal Β· up to 05691

This is a small generated-code cleanup that aligns the bindings with the current scheduler API. No behavior change is expected, and no merge-blocking risk has been identified.

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly identifies the main change: removing the stale dynamoGraphDeploymentRef field from LPX bindings.
Description check βœ… Passed The description includes the required overview, details, reviewer starting point, related issue, and validation information. It clearly explains the generated-file change and its intended lack of beha…
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot Β· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@kathleenfrench
kathleenfrench enabled auto-merge (squash) October 1, 2026 19:15
@kathleenfrench

Copy link
Copy Markdown
Contributor Author

/ok to test 056916d

@kathleenfrench
kathleenfrench merged commit 85f15f5 into main Oct 1, 2026
117 checks passed
@kathleenfrench
kathleenfrench deleted the kfrench/drop-stale-lpx-dgd-ref branch October 1, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore deployment::k8s Relates to dynamo deployment in kubernetes size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants