Repository navigation
chore(operator): drop stale dynamoGraphDeploymentRef from LPX bindings - #15522
Conversation
Regenerate the LPX scheduler API bindings from the current scheduler API. The scheduler no longer publishes materializationScope.dynamoGraphDeploymentRef, but this generated copy predates that removal and still declared it as a required field. Nothing in the operator reads or writes the field, and unknown JSON keys are ignored when decoding scheduler status, so behavior is unchanged. Signed-off-by: kathleen french <kfrench@nvidia.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Repository: ai-dynamo/dynamo/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: π Files selected for processing (1)
π€ Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe scheduler API removes ChangesMaterializationScope update
Priority: β¬οΈ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: βͺ Minimal Β· up to This is a small generated-code cleanup that aligns the bindings with the current scheduler API. No behavior change is expected, and no merge-blocking risk has been identified. π₯ Pre-merge checks | β 5β Passed checks (5 passed)
Comment |
|
/ok to test 056916d |
Overview:
Removes the stale
MaterializationScope.DynamoGraphDeploymentReffield from the operator's generated LPX scheduler bindings, so they match the current LPX scheduler API.Details:
deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.gois generated from the LPX scheduler API (Code generated by lpx-scheduler. DO NOT EDIT.). The scheduler'sLpuPipelineRequeststatus no longer includesmaterializationScope.dynamoGraphDeploymentRef. This copy predates that removal and still declares the field as required.DeepCopyIntoline; the rest of the generated file is byte-identical.deploy/operatorwith Go 1.26.6:go build ./..., plusgo vetandgo testfor./internal/dynamo/lpx/...and./internal/controller/lpx/....Where should the reviewer start?
deploy/operator/internal/dynamo/lpx/scheduler/v1alpha1/types.go: the two deleted lines inMaterializationScopeandMaterializationScope.DeepCopyInto.Related Issues
π This PR is linked to an issue:
Summary by CodeRabbit