[connorcarpenter15]

Overview:

Add a disaggregated KV-aware routing launcher for SGLang sidecars and align the existing sidecar launchers with Dynamo's standard configuration.

Details:

• Add disagg_kv_router.sh with two prefill and two decode SGLang engines, four native-gRPC sidecars, KV-event discovery, and Dynamo's KV-aware frontend router.
• Give every engine distinct GPU, HTTP, gRPC, KV-event, and system-port defaults, plus distinct bootstrap ports for the two prefill engines.
• Make the first aggregate sidecar honor DYN_SYSTEM_PORT1, then fall back to DYN_SYSTEM_PORT, then 8081.
• Remove unused OTEL_SERVICE_NAME assignments from the aggregate KV-router and disaggregated launchers.
• Validate the launchers with bash -n, ShellCheck, help/error-path checks, and the applicable pre-commit hooks.

Where should the reviewer start?

lib/sidecar/sglang/launch/disagg_kv_router.sh

Related Issues

⚠️ This section is required. Choose one path below and delete the other.

🚫 This PR is NOT linked to an issue:

• Confirmed — no related issue

Summary by CodeRabbit

• New Features
  • Added support for launching four SGLang sidecars with disaggregated prefill and decode engines.
  • Added configurable port resolution with sensible fallback defaults.
  • Added KV-routing and native gRPC configuration for multi-engine deployments.
• Chores
  • Simplified sidecar startup configuration by removing per-worker telemetry service naming.

[dynamo-ops]

/ok to test 4011c73

[github-actions]

👋 Hi connorcarpenter15! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

[dynamo-ops]

/ok to test 103407e

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 49ab43e0-ae90-439d-ae42-0379f265ec22

📥 Commits

Reviewing files that changed from the base of the PR and between 1758394 and 103407e.

📒 Files selected for processing (3)

• lib/sidecar/sglang/launch/agg_kv_router.sh
• lib/sidecar/sglang/launch/disagg.sh
• lib/sidecar/sglang/launch/disagg_kv_router.sh

💤 Files with no reviewable changes (1)

• lib/sidecar/sglang/launch/disagg.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

The changes add a disaggregated SGLang KV router launcher. They configure four engines and sidecars, add port fallback resolution, and remove worker-specific OTEL_SERVICE_NAME assignments.

Changes

SGLang KV router launch flow

Layer / File(s)	Summary
Port and environment resolution lib/sidecar/sglang/launch/agg_kv_router.sh, lib/sidecar/sglang/launch/disagg.sh	The scripts resolve system ports through environment fallbacks and remove worker-specific OTEL_SERVICE_NAME assignments.
Launcher configuration lib/sidecar/sglang/launch/disagg_kv_router.sh	The new launcher parses model and passthrough options, configures runtime defaults, registers cleanup, and starts the Dynamo frontend in KV router mode.
Engine and sidecar orchestration lib/sidecar/sglang/launch/disagg_kv_router.sh	The launcher starts two prefill engines, two decode engines, four Dynamo sidecars, and waits for any process to exit.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 10340

The PR adds and aligns SGLang sidecar launchers without any identified merge-blocking risk at the current head.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the primary change: adding disaggregated SGLang sidecar KV routing. It is concise and specific.
Description check	✅ Passed	The description covers the overview, implementation details, reviewer starting point, validation steps, and required issue-status section. It is complete and aligned with the changeset.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}