Error message when no input provided for question

Subject of the issue/enhancement/features

Questions (MCQ, GMCQ) don't provide any input when submit is pressed with no answer submitted.
The Matching component does prompt users but only does so by highlighting the dropdown boxes that haven't been selected. Text Input and Slider just takes the default value (empty or 1).

Your environment

version (AT/Framework) v5.6.0

Note: Proposed solution below, comments welcome.

IIRC it is supposed to highlight the instruction text in red...

Reference before Vanilla refactor: https://github.com/adaptlearning/adapt-contrib-vanilla/blob/157b98cc45d0febadfa6f5f3a4e07bfded586676/less/core/component.less#L45-L49.

We also have the option to do something different. Like a notify with a warning or similar.
Can confirm: New vanilla doesn't have above styling equivalent. Colour variables are there. Code executes properly. Class is added. Just no styling.

I agree it should be more than just colour as this wouldn't be accessible - https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-without-color.html

@oliverfoster

@oliverfoster switch to having the submit button disabled until the learner has met the canSubmit criteria?

Disabling the button sounds like a plan. The instruction text would have to make it pretty clear each time that an option needs to be selected. Slider might be an issue with any global button disablement, this is as the first option is always a valid selection.

Update: Slider is fine.

What do we think about the above PR?

PR in gif format:

looks good to me. increasingly this seems to be the desired behaviour for many of the clients I look after so it would be really helpful for this to be the default...

QUESTION:

Default to have Submit disabled before the conditions are met but add an optional setting to re-enabled.
Default to have Submit disabled before the conditions are met and make this behaviour the new unchangeable default.

Note: In case 1 it is possible leave the submit button enabled with no warning - which is the current behaviour.

it's a good question, I'll ask it on the forums and chat and see what people think...

I'll get the prs for matching and textinput done in the meantime.

Below:

👍 for default unchangeable. 2.

https://axesslab.com/disabled-buttons-suck/

I have added this as an alternative.

QUESTION:

Default to have Submit disabled before the conditions are met but add an optional setting to re-enabled.
Default to have Submit disabled before the conditions are met and make this behaviour the new unchangeable default.
Default to have Submit disabled before the conditions are met and have an alternative warning in-case it is needed for accessibility.

Note: In case 1 it is possible leave the submit button enabled with no warning - which is the current behaviour.

course.json: _buttons._incompleteWarning._isEnabled = true (defaults to false)

Thanks for asking for my feedback on this. I would like to discuss this with a colleague who is off work today so I will reply tomorrow if that is OK?

Sure. No worries. 👍 there's no immediate rush, it's been like this for while, a few more days won't hurt.

I don't understand how putting the behaviour in an extension obviates the need to add more config as we'd still need component level granularity.

because if we put the ‘disable submit by default‘ behaviour into an extension the configuration options for it would only be shown in the AAT when the extension is being used in a project i.e. for the majority of users we would not be adding any more config options.

Having an extension to turn off core feedback seems a bit weird.

I’m not sure what you mean by “an extension to turn off core feedback”... unless I’ve missed something this is not something that has been mentioned.

It sounds as though you'd like the strong feedback to be the primary use-case and have disable submit as the secondary in an extension to disable the strong feedback.

I was thinking the disable submit should be the primary use-case and the strong feedback should be the secondary extension as strong feedback is more specialised (checkbox mcqs) and feels more like a feature addition / an extension worthy bit of behaviour.

It's also a bit easier to implement that way round, in my head at least.

I guess an argument could be made that the strong feedback is more accessible and should be the default. But I don't like the idea of adding extra popups by default, especially as we're looking at doing inline feedback for a better mobile experience. Popups on mobile are a bit jarring.

Assuming by 'strong feedback' you mean 'display an error in a notify popup when the learner clicks submit without have made a valid selection' (as shown here) then yes I think I'm right in saying that myself, Chuck and Paul all feel it should be changed to this by default since the current system of showing a 'submission error' is a) currently broken and b) isn't very good even when it is working.

Yes I agree over-use of popups can be jarring but in the case of displaying an error then a popup seems to me to be a pretty normal thing to do.

I was thinking the disable feedback should be the primary use-case

That was my thinking too originally by I think that both Chuck and Paul have made good cases for the submit button to be left enabled by default.

and the strong feedback should be the secondary extension as strong feedback is more specialised (checkbox mcqs) and feels more like a feature addition / extension worthy bit of behaviour.

I'm not sure what you mean by 'more specialised', sorry. Perhaps we could pick this up in the Monday meeting as it feels like we're going round in circles here.

Cool. Sounds like a plan. We've got a clear idea of the solutions.

@simondate

@simondate / @chucklorenz / @paul-mediakitchen would you like to join the meeting on Monday to talk this through and offer opinions/suggestions? The meeting is normally midday BST but if it would be more convenient to make it later (particularly for Chuck!) then please suggest a time.

Anytime after 2 pm BST on Monday is good for me.

I'm currently helping a client create a theme in Adapt and they've hired an Accessibility testing company to test it, it was actually from their testing that I created this issue in the first place.

I have a meeting with them at 1 pm so I can ask their opinion about this issue and their recommended implementation. Then have it ready to share with you guys.

@simondate

@simondate that sounds like it could be really useful feedback, thanks!

Thanks for the invite--much appreciated, but I'm pressed for time on Monday. I won't being attending this time. You've validated my main concern that the current strategy that relies on styling the Instruction is too weak a solution. And I echo the general sentiment that the number of config options in the AAT can get burdensome (oh, for a way to hide "advanced" configs...). Seems to me the issue of whether to enable or disable the Submit is a matter of UX in a learning context. I suspect that you folks can represent the needs of learning designers better than I. One last thought: is there benefit from taking a clue from other authoring tools such as Storyline? Seems many designers bring their Storyline experience/expectations to their Adapt projects. Cheers!

@simondate

@simondate that sounds excellent. In the past we have had content tested by the Digital Accessibility Centre (DAC) - and they produced a very comprehensive report.

BTW happy to join the call today. My colleague Ian Robinson (fellow developer) would like to join too if that is OK? Is it at 2pm?

@paul-mediakitchen yes of course; it'll be 16.00 BST at this url https://hangouts.google.com/call/8g_asKG_3vA2A0BILi_mACEI

@moloko

Great thanks @moloko

Implemented as discussed. Extension link is included on the pr with a new repo in adaptlearning. I haven't yet registered the plugin and the supported framework version will need bumping once the pr is released.

@simondate

@simondate this should all be working now with the core components on their master branches, could you check?

git clone https://github.com/adaptlearning/adapt_framework/ ./reset/
cd ./reset/
adapt devinstall && npm install
grunt dev

Install this extension for the alternative https://github.com/adaptlearning/adapt-contrib-instructionError

Navigation Menu

Repository navigation

Error message when no input provided for question #2812

Subject of the issue/enhancement/features

Your environment

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Error message when no input provided for question #2812

Description

Subject of the issue/enhancement/features

Your environment

Activity

moloko commented on Jun 22, 2020

tomgreenfield commented on Jun 23, 2020

oliverfoster commented on Jun 23, 2020

simondate commented on Jun 23, 2020

moloko commented on Jun 23, 2020

oliverfoster commented on Jun 23, 2020

oliverfoster commented on Jun 23, 2020

moloko commented on Jun 23, 2020

oliverfoster commented on Jun 23, 2020

moloko commented on Jun 23, 2020

oliverfoster commented on Jun 23, 2020

chucklorenz commented on Jun 23, 2020

oliverfoster commented on Jun 23, 2020

paulstevenuk commented on Jun 24, 2020

oliverfoster commented on Jun 24, 2020

13 remaining items

moloko commented on Jun 27, 2020

oliverfoster commented on Jun 27, 2020

moloko commented on Jun 27, 2020

oliverfoster commented on Jun 27, 2020

moloko commented on Jun 27, 2020

simondate commented on Jun 27, 2020

moloko commented on Jun 27, 2020

chucklorenz commented on Jun 28, 2020

paulstevenuk commented on Jun 29, 2020

paulstevenuk commented on Jun 29, 2020

moloko commented on Jun 29, 2020

paulstevenuk commented on Jun 29, 2020

oliverfoster commented on Jun 29, 2020

oliverfoster commented on Jul 30, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions