[danwkennedy]

Description

We have reports of older archive files being uploaded (with the v4 action) and the downloaded Content-Disposition returns a file without the .zip extension. This only happens when the artifact name has a file type extension (ie. report.txt). This adds tests for that scenario so we can know when we're green again.

[Copilot]

Pull request overview

Adds an end-to-end workflow regression test to detect cases where an archived artifact’s Content-Disposition filename does not include the expected .zip suffix when the artifact name itself has a misleading extension (e.g. .txt).

Changes:

• Upload an artifact named like report.txt-<runner> to simulate a name/content-type mismatch.
• Download that artifact with skip-decompress: true and assert the saved filename ends in .zip.

Comments suppressed due to low confidence (1)

.github/workflows/test.yml:170

• This actions/upload-artifact@v4 step is missing a name: field. Most steps in this workflow are named, and naming this one will make the job log much easier to read/debug when failures happen around this regression test.

    - uses: actions/upload-artifact@v4 # V4 is important here to ensure we're supporting older versions correctly
      with:
        name: report.txt-${{ matrix.runs-on }}
        path: path/to/extension-test/data.json

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The step name says "Create and upload..." but this step only creates the input file; the upload happens in the following actions/upload-artifact@v4 step. Consider splitting this into two clearly named steps (e.g., "Create artifact payload" and "Upload artifact with misleading extension") so the workflow logs accurately reflect what happened.

This issue also appears on line 167 of the same file.

Suggested change

	- name: Create and upload archived artifact with misleading extension
	shell: bash
	run: |
	mkdir -p path/to/extension-test
	echo '{"key": "value"}' > path/to/extension-test/data.json
	- uses: actions/upload-artifact@v4 # V4 is important here to ensure we're supporting older versions correctly
	with:
	name: report.txt-${{ matrix.runs-on }}
	path: path/to/extension-test/data.json
	- name: Create archived artifact payload with misleading extension
	shell: bash
	run: |
	mkdir -p path/to/extension-test
	echo '{"key": "value"}' > path/to/extension-test/data.json
	- name: Upload archived artifact with misleading extension
	uses: actions/upload-artifact@v4 # V4 is important here to ensure we're supporting older versions correctly
	with:
	name: report.txt-${{ matrix.runs-on }}
	path: path/to/extension-test/data.json