You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add sanitization, validation, and basic tests for the error_count input parameter #172
Add sanitization, validation, and basic tests for the error_count input parameter.
Some possible rules:
ensure it is a finite number
ensure it is greater than 0
[optional] ensure it is less than the finalized timeout input parameter value (which may be adjusted to MAX_TIMEOUT, depending on the user's input) divided by the finalized reporting_interval
That is optional as it's unlikely that every single status check will report a temporary recoverable error 🤷🏻
Also, allowing the users to specify a number greater than that gives them the opportunity to allow as many errors as possible before timing out, which is OK if that's what they really want 🤷🏻
Similar to the a part of the changes made for timeout as shown in PR:
@TWiStErRob Understandable confusion, but the behavior you're describing would be achieved with error_count: 1. In other words, "fail on the first error".
Activity
TWiStErRob commentedon Oct 25, 2023
Should this be
>= 0? because0means I want to allow no errors. Having> 0would force everyone to accept 1 error.JamesMGreene commentedon Nov 21, 2023
@TWiStErRob Understandable confusion, but the behavior you're describing would be achieved with
error_count: 1. In other words, "fail on the first error".