This repository was archived by the owner on Jun 23, 2022. It is now read-only.
Repository navigation
feat: add a new app_env to limit scan time - #421
Merged
Merged
Conversation
acelyc111
previously approved these changes
Mar 20, 2020
neverchanje
reviewed
Mar 23, 2020
neverchanje
approved these changes
Mar 23, 2020
acelyc111
approved these changes
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pegasus issue Limit long time scan operator shows, we should set a time threshold for rocksdb iterate operation to avoid long time scan. To make it more flexible, we provide a new app_env called
replica.rocksdb_iteration_threshold_time_msto config this option.