You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
x265: shared lib should be linked with -Bsymbolic and one other issue #209
See pull request #208. Recently, when I was building an x265 that supported multiple bit depths, I discovered a couple of issues with the patch that was introduced in TritonDataCenter/pkgsrc-legacy#455.
The first issue with the patch is that it went further than it needed to, and completely removed -Bsymbolic on SunOS when it was only necessary to remove it from the executable target. This breaks bit-depth introspection. Even if you don't care about bit-depth introspection, it's best to stay as close to upstream as possible; it's possible other programs that link x265 also rely on it being compiled with -Bsymbolic
The second issue is that the patch adds "-Wa,--noexecstack" to the linker flags, which does nothing.
There are 3 reasons it does nothing:
cmake only sends the flag to gcc at the linking stage, it is never sent during the compilation stage
x265 doesn't use gcc to assemble its handwritten assembly, it uses nasm (formerly yasm), so passing -Wa,--noexecstack in the correct place wouldn't help; gcc of course already marks its generated assembly without needing this flag
As the patch comment questions, solaris ld ignores this anyway; if you compile a one-file c-program with gcc7 from pkgsrc it's not marked as noexecstack
This isn't a big deal because the default for 64 bit executables is a nonexecutable stack, even if they don't have the appropriate ELF header. But I figured I may as well pass a flag that generates a PT_SUNWSTACK header since it's necessary to pass -mimpure-text anyway.
Activity
despair86 commentedon Jun 30, 2019
nice. I knew I was missing something in my own patch, but I hardly use symbolic linkage in my own projects 🤷🏻
Update to 3.22.2. From the changelog:
Update to 1.71.0
py-weasyprint: update to 50
py-weasyprint: update to 50
Add SoftHSM version 2.5.0.
Update inadyn to 2.5
Update to text-1.2.4.0
miller: update to 5.6.2.
cups-filters: Update to 1.27.4
nim: Update to 1.2.2
devel/ruby-logging: update to 2.3.0
(cad/klayout) Updated 0.25.6 to 0.25.9
dhewm3: Update to 1.5.1
89 remaining items
py-wcwidth: update to 0.7.0.
(sysutils/R-later) Updated 1.4.1 to 1.4.8
py-rpds-py: update to 2026.5.1.
devel/feluda: update to 1.13.0
Update to 4.43
news/bulletty: update to 0.3.0
news/bulletty: update to 0.3.0
py-gidgethub: update to 5.4.0.
Update to 20260402.0
p5-Perl-Tidy: update to 20260826.
net/xfr: update to 0.11.0
Update to 20260402.0
p5-Perl-Tidy: update to 20260826.
net/xfr: update to 0.11.0
misc/rozi: update to 0.0.33