Skip to content

Fix for #3414 - C# generated client using FormUrlEncodedContent instead of StringContent - #5029

Merged
RicoSuter merged 1 commit into
RicoSuter:masterfrom
ErikApption:master
Mar 29, 2025
Merged

RicoSuter merged 1 commit into
RicoSuter:masterfrom
ErikApption:master

Conversation

@ErikApption

Copy link
Copy Markdown
Contributor

This is a fix for #3414. When "x-www-form-urlencoded" is accepted, NSwag will generate an invalid client that sends url encoded form as "application/json". This change checks if "application/json" is accepted and will prioritize it.

  • renamed ConsumesFormUrlEncoded to ConsumesOnlyFormUrlEncoded in liquid templates
  • ConsumesOnlyFormUrlEncoded will be set to false if json is accepted

…uid templates

- ConsumesOnlyFormUrlEncoded will be set to false if json is accepted
@ErikApption

Copy link
Copy Markdown
Contributor Author

@RicoSuter anything I can do to help with this PR? without this, NSwag generates invalid clients

@RicoSuter
RicoSuter merged commit 71ae244 into RicoSuter:master Mar 29, 2025
@RicoSuter

Copy link
Copy Markdown
Owner

Thanks for the PR.
Hopefully this does not break anyone..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants