Skip to content

Fix for unwanted parameter explosion in C# client - #5016

Merged
RicoSuter merged 2 commits into
RicoSuter:masterfrom
simonnieder:master
Mar 29, 2025
Merged

RicoSuter merged 2 commits into
RicoSuter:masterfrom
simonnieder:master

Conversation

@simonnieder

Copy link
Copy Markdown
Contributor

In response to #4310, since it seems like there will be no follow-up.

In the current implementation the parameter name is specified every time in the request:
/users?id=3&id=4&id=5

However, as per specification, if we set explode to false, we would expect:
/users?id=3,4,5

This pull request removes the unnecessary explosion, when explode is set to false, for arrays with collectionFormat "csv" and in the case when no collectionFormat is set.

@RicoSuter
RicoSuter merged commit 05a99f1 into RicoSuter:master Mar 29, 2025
@RicoSuter

Copy link
Copy Markdown
Owner

thx for the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants