Repository navigation
Add packets CCloseContainer, CSetContainerProperty and SCloseContainer - #59
Merged
Merged
Conversation
Contributor
Author
|
I think the abstraction I made is okay, but I'd love to get feedback on it |
Bryntet
changed the title
kralverde
suggested changes
Aug 23, 2024
kralverde
reviewed
Aug 23, 2024
Contributor
Author
|
ah, trying to solve the merge conflicts broke things |
Snowiiii
reviewed
Aug 24, 2024
| )) | ||
| } | ||
|
|
||
| /// The official Minecraft client is weird, and will always just close *any* window that is opened when this gets sent |
Contributor
Author
There was a problem hiding this comment.
I should probably change the wording from weird, but it's mainly just a note so that people won't try and depend on behaviour that only a specific window will be closed, when which window_id you send doesn't actually matter to the client
Contributor
Author
There was a problem hiding this comment.
What I think I meant to comment on as weird is that the packet still requires an ID, but it never gets used for anything.
composalagent Bot
pushed a commit
to vex-demo-1/Pumpkin
that referenced
this pull request
Sep 26, 2026
Add packets CCloseContainer, CSetContainerProperty and SCloseContainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the packets CCloseContainer and CSetContainerProperty and made abstractions for ContainerProperty.