Fix issue with incomplete results when completing paths with wildcards in non-filesystem providers - #24757
Merged
Conversation
โฆs in non-filesystem providers
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Ilya <darpa@yandex.ru>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
|
Rain Sallow (/u/ta11ow) (@vexx32) Is anything you want to discuss with WG or we can merge? |
Collaborator
|
As long as you're happy with the tests and behaviour after the fix, I think this is okay to merge, myself. Just wanted to make sure it got a review. |
Ilya (iSazonov)
approved these changes
Feb 25, 2025
Contributor
|
๐ฃ Hey MartinGC94, how did we do? We would love to hear your feedback with the link below! ๐ฃ๏ธ ๐ https://aka.ms/PSRepoFeedback |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
โฆs in non-filesystem providers (PowerShell#24757)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Replaces an early return with a continue so the completion code continues to evaluate other resolved paths when encountering an empty path.
This resolves scenarios like:
where you wouldn't get
HKCU:\AB2\Testin the results because AB1 is empty.PR Context
Fixes: #24756
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).